[Ml-yokadi] task recurrence

[Sébastien Renard]

Le dimanche 17 mai 2009 21:46:39, Aurélien Gâteau a écrit :
> Sébastien Renard wrote:
> > Hello,
> >
> > Please find on "recurrence" git branch a first implementation of
> > recurring tasks.
>
> Looks good! I will soon be able to schedule my car visits to the garage :)

Hope it's not weekly yet ;-).

> A few remarks, though:
> - For consistency, please use camelCase naming for Recurrence methods

Sure.

> - It would be nice to have some unit-tests for this feature

Yes.

> - The syntax to specify the weekday in case of weekly recursion could be
> made a bit more forgiving: for example allowing full day name and
> localized day name instead of only using the first two chars.
> I also suggest lowercasing the whole line before parsing it, to ensure
> we do not reject a day written with an upper-cased first letter.

Right.

> - What do you mean with "recurrence table should fill up and a cleanup
> process should be defined"?

Each time you define a new recurrence, a new line is created is Recurrence 
table. The old one is still there. 
In fact, it does not need a cleanup mechanism but a smarter update mode that 
overwrite previous recurrence (if exists) instead of create a new one each 
time it is changed. Quite easy to do.

a+
-- 
Sébastien