[Ml-yokadi] task recurrence

[Sébastien Renard]

Le dimanche 17 mai 2009 21:46:39, Aurélien Gâteau a écrit :
> Sébastien Renard wrote:
> > Hello,
> >
> > Please find on "recurrence" git branch a first implementation of
> > recurring tasks.
>
> Looks good! I will soon be able to schedule my car visits to the garage :)
>
> A few remarks, though:
> - For consistency, please use camelCase naming for Recurrence methods

Done.

> - It would be nice to have some unit-tests for this feature

Done.

> - The syntax to specify the weekday in case of weekly recursion could be
> made a bit more forgiving: for example allowing full day name and
> localized day name instead of only using the first two chars.
> I also suggest lowercasing the whole line before parsing it, to ensure
> we do not reject a day written with an upper-cased first letter.

Done, except localization that is a global yokadi question I do not want to 
answer only on this particular part.

> - What do you mean with "recurrence table should fill up and a cleanup
> process should be defined"?

That was a mess that is now fixed.

I fix some mistake and add monthly recurrence (still not good for your car, 
but it's still better than weekly :D).

The migration script is also done. So I merge the 'recurrence' branch on 
master. I hope it will not break on your side. I've just migrate my production 
database and everything run smooth for now.

a+
-- 
Sébastien