[Ml-yokadi] Note support

[Sébastien Renard]

Le vendredi 26 février 2010 23:35:03, Aurélien Gâteau a écrit :
> Hi,

Hello 

> What is a note? A note is reference information you want to attach to a
> project. It is not a task: it does not need to be done. Until now I have
> been creating notes by creating tasks with the @note keyword. This works
> reasonably well, but it results in the output of t_list being cluttered
> with rows which are not actionable items.

I agree with note concept. I don't use it a lot, but I fully understand the 
need.
 
> I built on this to implement note support: internally a note is a task
> with the @note keyword (will probably move to @_note before release).
> This means it is easy to turn a task into a note and vice-versa.

Ok.
 
> I added two new commands:
> - n_add creates a note (ie, a task with the @note keyword).
> - n_list lists only notes.
> 
> I also modified t_list to skip tasks with the @note keyword.
> 
> What do you think of this?

I agree with your first patch. We may want to unclutter taskcmd.py by creating 
other modules for bugs and notes with subclass of TaskCmd ?

About the second patch. ouhou, that's much a big t_list refactoring than a 
code reuse ;-).
That was very needed, as do_t_list was getting much and much harder to read.

Some comments : 
- we may move _parseListLine outside taskcmd.py ? In parseutils.py for ex. ? 
It just need extra args : self.pFilters and self.kFilters.
- idem for _renderList (which is easier to move) but I don't know where...
- Did you only split the code into small functions or do you also change 
t_list behaviour ? (except small things like changing tui.error with 
Y.Except.)
- I agree with change note to _note to be consistent with bug keywords.

a+
-- 
Sébastien