[Ml-yokadi] Note support

Aurélien Gâteau aurelien.gateau at free.fr
Tue Mar 9 23:44:57 CET 2010


On 03/07/10 18:12, Sébastien Renard wrote:
>> I added two new commands:
>> - n_add creates a note (ie, a task with the @note keyword).
>> - n_list lists only notes.
>>
>> I also modified t_list to skip tasks with the @note keyword.
>>
>> What do you think of this?
>
> I agree with your first patch. We may want to unclutter taskcmd.py by creating
> other modules for bugs and notes with subclass of TaskCmd ?

It's true taskcmd.py is getting quite large, but why do you think those 
new modules should be subclasses of TaskCmd?
>
> About the second patch. ouhou, that's much a big t_list refactoring than a
> code reuse ;-).
> That was very needed, as do_t_list was getting much and much harder to read.

Yes, do_t_list got quite shorter :)
>
> Some comments :
> - we may move _parseListLine outside taskcmd.py ? In parseutils.py for ex. ?
> It just need extra args : self.pFilters and self.kFilters.

I am not sure because I feel it is very specific to [tn]_list, I can't 
see any way to reuse this for other commands.

> - idem for _renderList (which is easier to move) but I don't know where...

Actually I am wondering whether it would make sense to create a module 
dedicated to task/note listing...

> - Did you only split the code into small functions or do you also change
> t_list behaviour ? (except small things like changing tui.error with
> Y.Except.)

The only behavior change is that t_list now skips tasks which have the 
@note keyword. Any other behavior change is a bug :)

> - I agree with change note to _note to be consistent with bug keywords.

Will do, but I want to implement k_edit before, so that it's easy for me 
to migrate... The only tricky part here is the case where one tries to 
rename a keyword using an existing keyword name. I think Yokadi should 
ask whether the user wants to merge keywords in this case. What do you 
think?

Aurélien


More information about the Ml-yokadi mailing list